Fix navigation keyboard accessibility #9951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
design
juliusknorr
approved these changes
Jun 21, 2018
|
So it is about the 3-dots menut for more apps, right? As the regular app menu icons were already keyboard browsable for me even before that. |
Codecov Report
@@ Coverage Diff @@
## master #9951 +/- ##
=========================================
Coverage 52.09% 52.09%
Complexity 25944 25944
=========================================
Files 1645 1645
Lines 95828 95828
Branches 1290 1290
=========================================
Hits 49917 49917
Misses 45911 45911 |
skjnldsv
approved these changes
Jun 21, 2018
|
@juliushaertl no, this is about app-navigation, the element :) the left sidebar, so to say. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the app-navigation accessible via keyboard. As discussed @skjnldsv
You can test via simply using Tab and Shift-Tab to navigate, and Enter to choose. Please review @nextcloud/designers @nextcloud/accessibility